Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix footer market stats #1976

Merged
merged 2 commits into from
Oct 13, 2023
Merged

Fix footer market stats #1976

merged 2 commits into from
Oct 13, 2023
+25 −8

Conversation

bogdanfazakas
Copy link
Member

@bogdanfazakas bogdanfazakas commented Oct 11, 2023 •
edited
Loading

Fixes #1963 .

Changes proposed in this PR:

  • fixes footer stats

Screenshot 2023-10-11 at 10 23 55

@vercel
Copy link

vercel bot commented Oct 11, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
market ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 13, 2023 9:51am
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
dubai-challenge ⬜️ Ignored (Inspect) Visit Preview Oct 13, 2023 9:51am

@bogdanfazakas bogdanfazakas marked this pull request as ready for review October 11, 2023 07:56
@jamiehewitt15
Copy link
Member

For a second or two, before it loads the data, it shows this weird message about free locked, free allocated. Can we change it so the footer message doesn't show until the data has loaded?

image

@bogdanfazakas
Copy link
Member Author

For a second or two, before it loads the data, it shows this weird message about free locked, free allocated. Can we change it so the footer message doesn't show until the data has loaded?

image

I'll try to quickly add a loader here as well

@LoznianuAnamaria LoznianuAnamaria self-requested a review October 13, 2023 08:50
@LoznianuAnamaria
Copy link
Contributor

I wouldn't spend too much time on this, it's good enough

@codeclimate
Copy link

codeclimate bot commented Oct 13, 2023

Code Climate has analyzed commit d3e32f1 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 0.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 20.1% (0.0% change).

View more on Code Climate.

@LoznianuAnamaria LoznianuAnamaria merged commit 1514e78 into main Oct 13, 2023
13 checks passed
@LoznianuAnamaria LoznianuAnamaria deleted the fix/footer-values branch October 13, 2023 10:48
@LucaMilanese90 LucaMilanese90 mentioned this pull request Oct 24, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LoznianuAnamaria LoznianuAnamaria LoznianuAnamaria approved these changes

@jamiehewitt15 jamiehewitt15 Awaiting requested review from jamiehewitt15 jamiehewitt15 is a code owner

@mihaisc mihaisc Awaiting requested review from mihaisc mihaisc is a code owner

@EnzoVezzaro EnzoVezzaro Awaiting requested review from EnzoVezzaro

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The footer is not updating
3 participants
@bogdanfazakas @jamiehewitt15 @LoznianuAnamaria